Skip to content

Conversation

@MaximilianAlgehed
Copy link
Collaborator

No description provided.

@MaximilianAlgehed
Copy link
Collaborator Author

@lehins the lts 22 and 23 builds of QuickCheck are apparently buggy (don't include 2.15.0.1, rather 2.15.0?). Perhaps this should be brought to the attention of the lts maintainers? Anyway, I've included lts 24 and nightly here because that appears to work.

@MaximilianAlgehed MaximilianAlgehed enabled auto-merge (squash) October 13, 2025 08:56
Copy link
Collaborator

@neilmayhew neilmayhew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, although I don't have any experience with coveralls. I suggest you merge it and fix any problems later.

Also, I'm not sure I understood the discussion about buggy QuickCheck versions. However, maybe using the older Stackage LTS gets around that.

For future reference, you can use an extra-deps field in stack.yaml to force a particular version of a dependency.

@MaximilianAlgehed
Copy link
Collaborator Author

The QuickCheck issue was resolved by skipping some tests on old QuickCheck versions.

@MaximilianAlgehed MaximilianAlgehed merged commit b24b667 into master Oct 17, 2025
9 checks passed
@MaximilianAlgehed MaximilianAlgehed deleted the coveralls branch October 17, 2025 06:03
@lehins
Copy link
Member

lehins commented Oct 20, 2025

the lts 22 and 23 builds of QuickCheck are apparently buggy (don't include 2.15.0.1, rather 2.15.0?).

This is not a bug, this is a feature. Both LTS-22 and 23 will forever include QuickCheck-2.14.3: https://www.stackage.org/lts-23.28/package/QuickCheck-2.14.3

It was only LTS-24 that started including QuickCheck-2.15 major version.
The way LTSs on stackage work is once a major version is included in the first snapshot, it will never switch to a new major version of a package, because that would bring breaking changes wit it and thus invalidate the concept of LTS.

@lehins
Copy link
Member

lehins commented Oct 20, 2025

Looks nice! https://coveralls.io/github/input-output-hk/constrained-generators

We might wanna include a badge somewhere in the README:

Coverage Status

[![Coverage Status](https://coveralls.io/repos/github/input-output-hk/constrained-generators/badge.svg?branch=master)](https://coveralls.io/github/input-output-hk/constrained-generators?branch=master)

MaximilianAlgehed added a commit that referenced this pull request Oct 21, 2025
* Implement coveralls support
MaximilianAlgehed added a commit that referenced this pull request Oct 21, 2025
* Implement coveralls support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants