-
Notifications
You must be signed in to change notification settings - Fork 0
Coveralls and stack support #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a99f1b6 to
2aa941a
Compare
|
@lehins the lts 22 and 23 builds of QuickCheck are apparently buggy (don't include 2.15.0.1, rather 2.15.0?). Perhaps this should be brought to the attention of the lts maintainers? Anyway, I've included lts 24 and nightly here because that appears to work. |
6194bbc to
66b99a8
Compare
1b9644a to
6c80daa
Compare
neilmayhew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, although I don't have any experience with coveralls. I suggest you merge it and fix any problems later.
Also, I'm not sure I understood the discussion about buggy QuickCheck versions. However, maybe using the older Stackage LTS gets around that.
For future reference, you can use an extra-deps field in stack.yaml to force a particular version of a dependency.
|
The QuickCheck issue was resolved by skipping some tests on old QuickCheck versions. |
This is not a bug, this is a feature. Both LTS-22 and 23 will forever include QuickCheck-2.14.3: https://www.stackage.org/lts-23.28/package/QuickCheck-2.14.3 It was only LTS-24 that started including QuickCheck-2.15 major version. |
|
Looks nice! https://coveralls.io/github/input-output-hk/constrained-generators We might wanna include a badge somewhere in the README: |
* Implement coveralls support
* Implement coveralls support
No description provided.